From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, URIBL_SBL,URIBL_SBL_A shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C92491F4B4 for ; Tue, 8 Dec 2020 21:21:30 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/6] minor internal consistency things Date: Tue, 8 Dec 2020 21:21:24 +0000 Message-Id: <20201208212130.5832-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Some more changes because the codebase needs to grow to support client-side tooling and JMAP. Lack of static type-checking means we need to be more consistent with naming conventions to avoid confusing my easily-confused mind. Eric Wong (6): treewide: replace {-inbox} with {ibx} for consistency nntp: replace {ng} with {ibx} for consistency rename {pi_config} fields to {pi_cfg} extindex: do not use current dir like -index does admin: resolve_repo_dir => resolve_inboxdir extsearchidx: ck_existing: set $OID for warning context Documentation/mknews.perl | 4 +- examples/cgit.psgi | 4 +- lib/PublicInbox/Admin.pm | 8 +- lib/PublicInbox/Cgit.pm | 24 +++--- lib/PublicInbox/Config.pm | 2 +- lib/PublicInbox/ExtMsg.pm | 18 ++--- lib/PublicInbox/ExtSearchIdx.pm | 2 + lib/PublicInbox/Feed.pm | 6 +- lib/PublicInbox/Filter/RubyLang.pm | 2 +- lib/PublicInbox/GzipFilter.pm | 4 +- lib/PublicInbox/IMAPD.pm | 28 +++---- lib/PublicInbox/Inbox.pm | 10 +-- lib/PublicInbox/InboxIdle.pm | 9 +-- lib/PublicInbox/InboxWritable.pm | 2 +- lib/PublicInbox/MDA.pm | 4 +- lib/PublicInbox/ManifestJsGz.pm | 2 +- lib/PublicInbox/Mbox.pm | 30 +++---- lib/PublicInbox/MboxGz.pm | 4 +- lib/PublicInbox/NNTP.pm | 124 ++++++++++++++--------------- lib/PublicInbox/NNTPD.pm | 16 ++-- lib/PublicInbox/NewsWWW.pm | 15 ++-- lib/PublicInbox/Qspawn.pm | 4 +- lib/PublicInbox/SearchThread.pm | 4 +- lib/PublicInbox/SearchView.pm | 14 ++-- lib/PublicInbox/Spamcheck.pm | 4 +- lib/PublicInbox/Unsubscribe.pm | 6 +- lib/PublicInbox/View.pm | 22 ++--- lib/PublicInbox/ViewVCS.pm | 2 +- lib/PublicInbox/WWW.pm | 51 ++++++------ lib/PublicInbox/Watch.pm | 20 ++--- lib/PublicInbox/WwwAltId.pm | 2 +- lib/PublicInbox/WwwAtomStream.pm | 10 +-- lib/PublicInbox/WwwAttach.pm | 10 +-- lib/PublicInbox/WwwListing.pm | 4 +- lib/PublicInbox/WwwStream.pm | 12 +-- lib/PublicInbox/WwwText.pm | 12 +-- script/public-inbox-index | 1 + script/public-inbox-learn | 8 +- script/public-inbox-mda | 8 +- scripts/import_slrnspool | 4 +- t/admin.t | 28 ++++--- t/feed.t | 6 +- t/filter_rubylang.t | 2 +- t/imapd.t | 4 +- t/inbox_idle.t | 8 +- t/mda_filter_rubylang.t | 4 +- t/nntp.t | 12 +-- t/psgi_mount.t | 6 +- t/psgi_search.t | 6 +- t/psgi_v2.t | 11 ++- t/watch_filter_rubylang.t | 10 +-- t/watch_maildir.t | 26 +++--- t/watch_maildir_v2.t | 48 +++++------ t/watch_multiple_headers.t | 8 +- xt/cmp-msgview.t | 2 +- xt/perf-msgview.t | 2 +- xt/perf-threading.t | 2 +- 57 files changed, 352 insertions(+), 349 deletions(-)