From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] searchidxshard: chomp $eidx_key from pipe
Date: Sat, 28 Nov 2020 07:06:50 +0000 [thread overview]
Message-ID: <20201128070650.13191-1-e@80x24.org> (raw)
We were accidentally adding "\n" to terms (which Xapian happily
accepts), causing incompatibilities when enabling parallel
sharding in some invocations of -extindex but not others.
This is an extindex incompatibility and starting a new extindex
will be required to take advantage of in-development features,
so it's not urgent to start another one, either.
(other incompatible things may happen before a 1.7 release)
---
lib/PublicInbox/SearchIdxShard.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index 875a9ec9..dcfeb0be 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -83,11 +83,13 @@ sub shard_worker_loop ($$$$$) {
} elsif ($line =~ s/\A\+X //) {
my ($len, $docid, $oid, $eidx_key) =
split(/ /, $line, 4);
+ chomp $eidx_key;
$self->add_eidx_info($docid, $oid, $eidx_key,
eml($r, $len));
} elsif ($line =~ s/\A-X //) {
my ($len, $docid, $oid, $eidx_key) =
split(/ /, $line, 4);
+ chomp $eidx_key;
$self->remove_eidx_info($docid, $oid, $eidx_key,
eml($r, $len));
} else {
reply other threads:[~2020-11-28 7:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128070650.13191-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).