From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 829241FB06 for ; Mon, 23 Nov 2020 07:06:03 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 07/12] extsearch: fix remaining "eindex" references Date: Mon, 23 Nov 2020 07:05:57 +0000 Message-Id: <20201123070602.9698-8-e@80x24.org> In-Reply-To: <20201123070602.9698-1-e@80x24.org> References: <20201123070602.9698-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We'll replace "$EINDEX" => "$EXTINDEX" in a user-visible line and also some hacker-only tests. "eindex" is no longer used because it rhymes with "reindex", so remove the last instance of it. Fixes: 6b0fed3b03263ba2 ("extsearch: rename -eindex to -extindex") --- lib/PublicInbox/ExtSearch.pm | 2 +- t/extsearch.t | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/ExtSearch.pm b/lib/PublicInbox/ExtSearch.pm index c41ae443..dd93cd32 100644 --- a/lib/PublicInbox/ExtSearch.pm +++ b/lib/PublicInbox/ExtSearch.pm @@ -57,7 +57,7 @@ sub description { my ($self) = @_; ($self->{description} //= PublicInbox::Inbox::cat_desc("$self->{topdir}/description")) // - '$EINDEX_DIR/description missing'; + '$EXTINDEX_DIR/description missing'; } sub cloneurl { [] } # TODO diff --git a/t/extsearch.t b/t/extsearch.t index dc825bf4..0045294b 100644 --- a/t/extsearch.t +++ b/t/extsearch.t @@ -35,9 +35,9 @@ seek($fh, 0, SEEK_SET) or BAIL_OUT $!; run_script(['-mda', '--no-precheck'], $env, { 0 => $fh }) or BAIL_OUT '-mda'; run_script(['-index', "$home/v1test"]) or BAIL_OUT "index $?"; -ok(run_script([qw(-extindex --all), "$home/eindex"]), 'extindex init'); +ok(run_script([qw(-extindex --all), "$home/extindex"]), 'extindex init'); -my $es = PublicInbox::ExtSearch->new("$home/eindex"); +my $es = PublicInbox::ExtSearch->new("$home/extindex"); { my $smsg = $es->over->get_art(1); ok($smsg, 'got first article'); @@ -55,7 +55,7 @@ my $es = PublicInbox::ExtSearch->new("$home/eindex"); my $env = { MAIL_EDITOR => "$^X -i -p -e 's/test message/BEST MSG/'" }; my $cmd = [ qw(-edit -Ft/utf8.eml), "$home/v2test" ]; ok(run_script($cmd, $env, $opt), '-edit'); - ok(run_script([qw(-extindex --all), "$home/eindex"], undef, $opt), + ok(run_script([qw(-extindex --all), "$home/extindex"], undef, $opt), 'extindex again'); like($err, qr/discontiguous range/, 'warned about discontiguous range'); my $msg1 = $es->over->get_art(1) or BAIL_OUT 'msg1 missing';