unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] searchidx: check for graceful shutdown in log2stack
@ 2020-11-15  9:16 Eric Wong
  2020-11-15 23:20 ` [PATCH v2] " Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2020-11-15  9:16 UTC (permalink / raw)
  To: meta

The initial "git log" invocation for a git epoch can be time
consuming, so check for graceful shutdown at each line to ensure
timely shutdowns and avoid SSD/HDD wear.
---
 lib/PublicInbox/SearchIdx.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 90d8c8b3..1466b88b 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -753,6 +753,7 @@ sub log2stack ($$$) {
 				$range);
 	my ($at, $ct, $stk, $cmt);
 	while (<$fh>) {
+		last if $sync->{quit};
 		if (/\A([0-9]+)-([0-9]+)-($OID)$/o) {
 			($at, $ct, $cmt) = ($1 + 0, $2 + 0, $3);
 			$stk //= PublicInbox::IdxStack->new($cmt);
@@ -775,7 +776,9 @@ sub log2stack ($$$) {
 			$stk->push_rec('m', $at, $ct, $oid, $cmt);
 		}
 	}
-	close $fh or die "git log failed: \$?=$?";
+	unless (close $fh) {
+		die "git log failed: \$?=$?" unless $sync->{quit};
+	}
 	$stk //= PublicInbox::IdxStack->new;
 	$stk->read_prepare;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2] searchidx: check for graceful shutdown in log2stack
  2020-11-15  9:16 [PATCH] searchidx: check for graceful shutdown in log2stack Eric Wong
@ 2020-11-15 23:20 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2020-11-15 23:20 UTC (permalink / raw)
  To: meta

The initial "git log" invocation for a git epoch can be time
consuming, so check for graceful shutdown at each line to ensure
timely shutdowns and avoid SSD/HDD wear.
---
 v2: much simpler than v1, since log2stack and prepare_stack
     callers already understand a `undef' return value.

 lib/PublicInbox/SearchIdx.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 90d8c8b3..6ff2cf94 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -753,6 +753,7 @@ sub log2stack ($$$) {
 				$range);
 	my ($at, $ct, $stk, $cmt);
 	while (<$fh>) {
+		return if $sync->{quit};
 		if (/\A([0-9]+)-([0-9]+)-($OID)$/o) {
 			($at, $ct, $cmt) = ($1 + 0, $2 + 0, $3);
 			$stk //= PublicInbox::IdxStack->new($cmt);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-15 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15  9:16 [PATCH] searchidx: check for graceful shutdown in log2stack Eric Wong
2020-11-15 23:20 ` [PATCH v2] " Eric Wong

unofficial mirror of meta@public-inbox.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://yhetil.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.public-inbox.meta
	nntp://news.public-inbox.org/inbox.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git