From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DD0721F86C for ; Sat, 7 Nov 2020 10:57:01 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 02/10] extsearchidx: avoid needless alternates rewrite in ALL.git Date: Sat, 7 Nov 2020 10:56:52 +0000 Message-Id: <20201107105700.12586-3-e@80x24.org> In-Reply-To: <20201107105700.12586-1-e@80x24.org> References: <20201107105700.12586-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: As with fill_alternates in V2Writable, we do not need to update $GIT_DIR/objects/info/alternates if nothing is changed. --- lib/PublicInbox/ExtSearchIdx.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 9d576adb..9da42538 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -380,8 +380,11 @@ sub idx_init { # similar to V2Writable $new{$line} = 1; push @new, $line; } - push @old, @new; - PublicInbox::V2Writable::write_alternates($info_dir, $mode, \@old); + if (scalar @new) { + push @old, @new; + my $o = \@old; + PublicInbox::V2Writable::write_alternates($info_dir, $mode, $o); + } $self->parallel_init($self->{indexlevel}); $self->umask_prepare; $self->with_umask(\&PublicInbox::V2Writable::_idx_init, $self, $opt);