From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B82401FA10 for ; Sat, 7 Nov 2020 10:57:07 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 10/10] extindex: fix --batch-size support Date: Sat, 7 Nov 2020 10:57:00 +0000 Message-Id: <20201107105700.12586-11-e@80x24.org> In-Reply-To: <20201107105700.12586-1-e@80x24.org> References: <20201107105700.12586-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Calling PublicInbox::Admin::index_prepare is required for --batch-size (k|m|g) modifiiers and indexBatchSize in the config file. Otherwise, the default 1m batch size stuck and led to unexpectedly bad performance on a machine which could index v2 inboxes faster with larger batch sizes. --- script/public-inbox-extindex | 2 ++ 1 file changed, 2 insertions(+) diff --git a/script/public-inbox-extindex b/script/public-inbox-extindex index 864a2732..5d56e2c3 100644 --- a/script/public-inbox-extindex +++ b/script/public-inbox-extindex @@ -39,6 +39,8 @@ my $cfg = PublicInbox::Config->new; my @ibxs = PublicInbox::Admin::resolve_inboxes(\@ARGV, $opt, $cfg); PublicInbox::Admin::require_or_die(qw(-search)); PublicInbox::Admin::progress_prepare($opt); +my $env = PublicInbox::Admin::index_prepare($opt, $cfg); +local %ENV = (%ENV, %$env) if $env; require PublicInbox::ExtSearchIdx; my $eidx = PublicInbox::ExtSearchIdx->new($eidx_dir, $opt); $eidx->attach_inbox($_) for @ibxs;