From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 1264520099 for ; Tue, 27 Oct 2020 07:55:00 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 39/52] Makefile.PL: do not build manpage if POD is missing Date: Tue, 27 Oct 2020 07:54:40 +0000 Message-Id: <20201027075453.19163-40-e@80x24.org> In-Reply-To: <20201027075453.19163-1-e@80x24.org> References: <20201027075453.19163-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: But warn on it, this lets us test new or throwaway commands more easily if we don't have to start a new POD for everything we want to dump in script/. --- Makefile.PL | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index f6b7abb6..56679598 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -31,7 +31,18 @@ my @syn = (@EXE_FILES, grep(m!^lib/.*\.pm$!, @manifest), @scripts); @syn = grep(!/SaPlugin/, @syn) if !eval { require Mail::SpamAssasin }; $v->{syn_files} = \@syn; $v->{my_syntax} = [map { "$_.syntax" } @syn]; -$v->{-m1} = [ map { (split('/'))[-1] } @EXE_FILES ]; +my @no_pod; +$v->{-m1} = [ map { + my $x = (split('/'))[-1]; + my $pod = "Documentation/$x.pod"; + if (-f $pod) { + $x; + } else { + warn "W: $pod missing\n"; + push @no_pod, $x; + (); + } + } @EXE_FILES ]; $v->{-m5} = [ qw(public-inbox-config public-inbox-v1-format public-inbox-v2-format) ]; $v->{-m7} = [ qw(public-inbox-overview public-inbox-tuning) ]; @@ -109,6 +120,7 @@ my %man3 = map {; # semi-colon tells Perl this is a BLOCK (and not EXPR) $mod =~ s/\.\w+\z//; "lib/PublicInbox/$_" => "blib/man3/PublicInbox::$mod.3" } qw(Git.pm Import.pm WWW.pod SaPlugin/ListMirror.pod); +my $warn_no_pod = @no_pod ? "\n\t\@echo W: missing .pod: @no_pod\n" : ''; WriteMakefile( NAME => 'PublicInbox', # n.b. camel-case is not our choice @@ -172,6 +184,8 @@ $VARS -include Documentation/include.mk $TGTS +check-man ::$warn_no_pod + # syntax checks are currently GNU make only: %.syntax :: % @\$(PERL) -w -I lib -c \$<