From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] imap: avoid raising exception if client disconnects
Date: Sat, 26 Sep 2020 19:55:55 +0000 [thread overview]
Message-ID: <20200926195555.GA31457@dcvr> (raw)
In-Reply-To: <20200926080837.29266-1-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
> index e7ea7f7f..9327100c 100644
> --- a/lib/PublicInbox/IMAP.pm
> +++ b/lib/PublicInbox/IMAP.pm
> @@ -619,18 +619,19 @@ sub fetch_run_ops {
> sub fetch_blob_cb { # called by git->cat_async via git_async_cat
> my ($bref, $oid, $type, $size, $fetch_arg) = @_;
> my ($self, undef, $msgs, $range_info, $ops, $partial) = @$fetch_arg;
> + my $ibx = $self->{ibx} or return; # client disconnected
Encountering some (probably) Gcf2-related errors after this change.
PublicInbox::DS::close is idempotent, so maybe this is safer:
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 9327100c..be9c7dca 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -619,7 +619,7 @@ sub fetch_run_ops {
sub fetch_blob_cb { # called by git->cat_async via git_async_cat
my ($bref, $oid, $type, $size, $fetch_arg) = @_;
my ($self, undef, $msgs, $range_info, $ops, $partial) = @$fetch_arg;
- my $ibx = $self->{ibx} or return; # client disconnected
+ my $ibx = $self->{ibx} or return $self->close; # client disconnected
my $smsg = shift @$msgs or die 'BUG: no smsg';
if (!defined($oid)) {
# it's possible to have TOCTOU if an admin runs
prev parent reply other threads:[~2020-09-26 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 8:08 [PATCH] imap: avoid raising exception if client disconnects Eric Wong
2020-09-26 19:55 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926195555.GA31457@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).