unofficial mirror of
 help / color / mirror / Atom feed
From: Eric Wong <>
Subject: [PATCH 2/2] v2writable: drop outdated {unindex_range} check
Date: Tue, 22 Sep 2020 18:49:50 +0000
Message-ID: <> (raw)
In-Reply-To: <>

{unindex_range} only exists in the $sync state, nowadays, not the
V2Writable ($self) object.  $sync->{unindex_range} won't be
populated if $regen_max is zero, either, unless somebody is
injecting importable commits into an epoch history, in which
this change will result in no-op indexing doing no work.
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index b8abfa94..5ff2af10 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -1074,7 +1074,7 @@ sub sync_prepare ($$$) {
-	if (!$regen_max && !keys(%{$self->{unindex_range}})) {
+	if (!$regen_max) {
 		$sync->{-regen_fmt} = "%u/?\n";
 		return 0;

      parent reply	other threads:[~2020-09-22 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 18:49 [PATCH 0/2] more minor indexing fixes Eric Wong
2020-09-22 18:49 ` [PATCH 1/2] idxstack: fix comment about file_char Eric Wong
2020-09-22 18:49 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of

This inbox may be cloned and mirrored by anyone:

	git clone --mirror

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ \
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:

AGPL code for this site: git clone