Stuff noticed while working on detached index usability and maintainability... Eric Wong (2): idxstack: fix comment about file_char v2writable: drop outdated {unindex_range} check lib/PublicInbox/IdxStack.pm | 2 +- lib/PublicInbox/V2Writable.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
It's `d' for deletes, not `a'. --- lib/PublicInbox/IdxStack.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/IdxStack.pm b/lib/PublicInbox/IdxStack.pm index b43b8064..ce75b46a 100644 --- a/lib/PublicInbox/IdxStack.pm +++ b/lib/PublicInbox/IdxStack.pm @@ -14,7 +14,7 @@ sub new { bless { wr => $io, latest_cmt => $_[1] }, __PACKAGE__ } -# file_char = [a|m] +# file_char = [d|m] sub push_rec { my ($self, $file_char, $at, $ct, $blob_oid) = @_; my $rec = pack(FMT, $file_char, $at, $ct, $blob_oid);
{unindex_range} only exists in the $sync state, nowadays, not the V2Writable ($self) object. $sync->{unindex_range} won't be populated if $regen_max is zero, either, unless somebody is injecting importable commits into an epoch history, in which this change will result in no-op indexing doing no work. --- lib/PublicInbox/V2Writable.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index b8abfa94..5ff2af10 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -1074,7 +1074,7 @@ sub sync_prepare ($$$) { } $all->cat_async_wait; } - if (!$regen_max && !keys(%{$self->{unindex_range}})) { + if (!$regen_max) { $sync->{-regen_fmt} = "%u/?\n"; return 0; }