unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] imap: quiet uninitialized variable warning on FETCH
@ 2020-09-15  6:11 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-09-15  6:11 UTC (permalink / raw)
  To: meta

This was triggered by blindly trying to FETCH an MSN (not
"UID FETCH") on an empty dummy inbox.  It's harmless, and
probably triggered by a wayward client or misbehaving bot.
---
 lib/PublicInbox/IMAP.pm | 2 +-
 t/imapd.t               | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 2d0d005e..47c08aea 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -300,7 +300,7 @@ sub msn2uid ($) {
 # converts a set of message sequence numbers in requests to UIDs:
 sub msn_to_uid_range ($$) {
 	my $msn2uid = $_[0];
-	$_[1] =~ s!([0-9]+)!$msn2uid->[$1 - 1] // ($msn2uid->[-1] + 1)!sge;
+	$_[1] =~ s!([0-9]+)!$msn2uid->[$1 - 1] // ($msn2uid->[-1] // 0 + 1)!sge;
 }
 
 # called by PublicInbox::InboxIdle
diff --git a/t/imapd.t b/t/imapd.t
index cb95fa5d..c1c52839 100644
--- a/t/imapd.t
+++ b/t/imapd.t
@@ -371,6 +371,10 @@ EOF
 	@hits = $mic->search('SENTSINCE' => '18-Apr-2020');
 	is_deeply(\@hits, [], 'search on dummy with condition works');
 	ok(!$mic->search('SENTSINCE' => '18-Abr-2020'), 'bad month fails');
+	$mic->Uid(0);
+	my $ret = $mic->fetch_hash(2, 'RFC822');
+	is_deeply($ret, {},
+		'MSN FETCH on empty dummy will not trigger warnings, later');
 }); # each_inbox
 
 # message sequence numbers :<

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-15  6:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  6:11 [PATCH] imap: quiet uninitialized variable warning on FETCH Eric Wong

unofficial mirror of meta@public-inbox.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://yhetil.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.public-inbox.meta
	nntp://news.public-inbox.org/inbox.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git