From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C48AD1F670 for ; Wed, 9 Sep 2020 21:23:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] wwwtext: don't blindly quote "git clone" destination Date: Wed, 9 Sep 2020 21:23:25 +0000 Message-Id: <20200909212326.19561-3-e@80x24.org> In-Reply-To: <20200909212326.19561-1-e@80x24.org> References: <20200909212326.19561-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Save screen space and light up fewer pixels to reduce visual noise. --- lib/PublicInbox/WwwText.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm index 14470b45..99aec370 100644 --- a/lib/PublicInbox/WwwText.pm +++ b/lib/PublicInbox/WwwText.pm @@ -198,11 +198,11 @@ EOF if ($urls && scalar(@$urls)) { $$txt .= "\t; "; $$txt .= join(" ||\n\t;\t", map {; - my $cpath = $path; + my $dst = $path; if ($path !~ m![a-z0-9_/\.\-]!i) { - $cpath = dq_escape($cpath); + $dst = '"'.dq_escape($dst).'"'; } - qq(git clone $_ "$cpath"); + qq(git clone $_ $dst); } @$urls); $$txt .= "\n"; }