Re: [PATCH 3/3] tests: check-run: show skipped tests

[Eric Wong <e@yhbt.net>]

Eric Wong <e@yhbt.net> wrote:
> +				my %nr;
> +				$nr{$_}++ for @sk;
> +				for (@sk) {
> +					my $n = delete $nr{$_} or next;
> +					print OLDERR "$pfx$_ ($n)\n";
> +				}

That's longer than it needs to be, we can grep here, too.

diff --git a/t/run.perl b/t/run.perl
index e3e3e075..0ba5e044 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -80,11 +80,8 @@ sub test_status () {
 			my @sk = (<$fh> =~ m/^ok [0-9]+ (# skip [^\n]+)/mgs);
 			if (@sk) {
 				my %nr;
-				$nr{$_}++ for @sk;
-				for (@sk) {
-					my $n = delete $nr{$_} or next;
-					print OLDERR "$pfx$_ ($n)\n";
-				}
+				my @err = grep { !$nr{$_}++ } @sk;
+				print OLDERR "$pfx$_ ($nr{$_})\n" for @err;
 				$skip = ' # total skipped: '.scalar(@sk);
 			}
 		} else {