From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id ECA2D1F66E; Sat, 22 Aug 2020 20:30:34 +0000 (UTC) Date: Sat, 22 Aug 2020 20:30:34 +0000 From: Eric Wong To: Kyle Meyer Cc: meta@public-inbox.org Subject: Re: [PATCH 0/5] "mairix -t" workalike for mbox.gz downloads Message-ID: <20200822203034.GA27004@dcvr> References: <20200822060627.15595-1-e@yhbt.net> <20200822064237.GA15720@dcvr> <874koucue1.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874koucue1.fsf@kyleam.com> List-Id: Kyle Meyer wrote: > Eric Wong writes: > > Eric Wong wrote: > >> It requires "public-inbox-index --reindex" to activate; > >> but PATCH 5/5 makes it safe to upgrade WWW either before > >> or after --reindex. That means BOFHs can upgrade without > >> regard to ordering. > > > > public-inbox-watch users will need to restart -watch before > > --reindex, though. Don't think that's avoidable... > > Oops, the few times I've used --reindex I don't think I've given order > much thought. Is it accurate to say that "restart services then > --reindex" is the recommended order in general? Not really. In the distant past (pre-SCHEMA_VERSION=15), it was actually index (no need for --reindex) then restart daemons, because the daemons were running on SCHEMA_VERSION=14 (or whatever was before). This order is only needed since we're trying to stick to SCHEMA_VERSION=15 to avoid the space penalty of parallel versions. If we get to SCHEMA_VERSION=16, it'll again be index first (no need for --reindex), then restart -watch, then restart read-only daemons. Right now I don't see a need to do a SCHEMA_VERSION=16. However, there will very likely be an optional multi-inbox index in 1.7 which will run parallel to existing (xap15) indices. This multi-inbox index may be able to completely replace existing indices (and save space while doing so). But it'll be completely optional. In any case, the release notes will be updated with any necessary upgrade instructions.