* [PATCH] index: --sequential-shard checkpoints after each shard
@ 2020-08-22 19:51 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-08-22 19:51 UTC (permalink / raw)
To: meta
There's no reason we'd want Xapian to defer flushing once we've
indexed everything belonging to a particular shard.
---
lib/PublicInbox/V2Writable.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index b0148dba..3d6f19cb 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1264,8 +1264,11 @@ sub xapian_only {
$sync->{art_end} = $art_end;
if ($seq || !$self->{parallel}) {
my $shard_end = $self->{shards} - 1;
- for (0..$shard_end) {
- index_xap_step($self, $sync, $art_beg + $_)
+ for my $i (0..$shard_end) {
+ index_xap_step($self, $sync, $art_beg + $i);
+ if ($i != $shard_end) {
+ reindex_checkpoint($self, $sync);
+ }
}
} else { # parallel (maybe)
index_xap_step($self, $sync, $art_beg, 1);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-22 19:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 19:51 [PATCH] index: --sequential-shard checkpoints after each shard Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).