[PATCH] wwwlisting: fix grep call for match=domain filtering

[PATCH] wwwlisting: fix grep call for match=domain filtering

[Kyle Meyer]

The grep call in list_match_domain_i returns true for all inboxes,
even ones without a URL that matches the regular expression, because
the qr value passed to grep is not surrounded by slashes.  Add them.

Fixes: 1988d730c0088e8b (config: support multi-value inbox.*.*url)
---
 lib/PublicInbox/WwwListing.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index 5f85e346..0af0fe68 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -40,7 +40,7 @@ sub list_all ($$$) {
 sub list_match_domain_i {
 	my ($ibx, $arg) = @_;
 	my ($list, $hide_key, $re) = @$arg;
-	if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
+	if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {
 		push @$list, $ibx;
 	}
 }

base-commit: 9e0c2886493863b4bc6483ce0a3bfd3d599c8c87
-- 
2.27.0

Re: [PATCH] wwwlisting: fix grep call for match=domain filtering

[Eric Wong]

Kyle Meyer <kyle@kyleam.com> wrote:
> The grep call in list_match_domain_i returns true for all inboxes,
> even ones without a URL that matches the regular expression, because
> the qr value passed to grep is not surrounded by slashes.  Add them.
> 
> Fixes: 1988d730c0088e8b (config: support multi-value inbox.*.*url)

Thanks, pushed as commit 41ecd08ee60daa495de3a2fc2c0296dc9cc9a0b3

>  sub list_match_domain_i {
>  	my ($ibx, $arg) = @_;
>  	my ($list, $hide_key, $re) = @$arg;
> -	if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
> +	if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {

Gah, I keep getting languages/behaviors confused :x

Especially confusing since `$string =~ $re' is documented
in perlop(1) as being equivalent to `$string =~ /$re/'

Re: [PATCH] wwwlisting: fix grep call for match=domain filtering

[Kyle Meyer]

Eric Wong writes:

>>  sub list_match_domain_i {
>>  	my ($ibx, $arg) = @_;
>>  	my ($list, $hide_key, $re) = @$arg;
>> -	if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
>> +	if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {
>
> Gah, I keep getting languages/behaviors confused :x
>
> Especially confusing since `$string =~ $re' is documented
> in perlop(1) as being equivalent to `$string =~ /$re/'

Ah, good to know you find that bit in the documentation confusing too.
It had me scratching my head when I was debugging this, but I wasn't
sure if I was just missing something that would be obvious to someone
who knows perl.