From: Eric Wong <e@yhbt.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] wwwlisting: fix grep call for match=domain filtering
Date: Thu, 30 Jul 2020 08:03:54 +0000 [thread overview]
Message-ID: <20200730080353.GA14766@dcvr> (raw)
In-Reply-To: <20200730053055.30972-1-kyle@kyleam.com>
Kyle Meyer <kyle@kyleam.com> wrote:
> The grep call in list_match_domain_i returns true for all inboxes,
> even ones without a URL that matches the regular expression, because
> the qr value passed to grep is not surrounded by slashes. Add them.
>
> Fixes: 1988d730c0088e8b (config: support multi-value inbox.*.*url)
Thanks, pushed as commit 41ecd08ee60daa495de3a2fc2c0296dc9cc9a0b3
> sub list_match_domain_i {
> my ($ibx, $arg) = @_;
> my ($list, $hide_key, $re) = @$arg;
> - if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
> + if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {
Gah, I keep getting languages/behaviors confused :x
Especially confusing since `$string =~ $re' is documented
in perlop(1) as being equivalent to `$string =~ /$re/'
next prev parent reply other threads:[~2020-07-30 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 5:30 [PATCH] wwwlisting: fix grep call for match=domain filtering Kyle Meyer
2020-07-30 8:03 ` Eric Wong [this message]
2020-07-30 14:58 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730080353.GA14766@dcvr \
--to=e@yhbt.net \
--cc=kyle@kyleam.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).