unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: Re: [PATCH] v2writable: use {inboxdir} for msgmap->tmp_clone
Date: Wed, 29 Jul 2020 11:32:25 +0000	[thread overview]
Message-ID: <20200729113224.GB7999@dcvr> (raw)
In-Reply-To: <20200728232554.1762-1-e@yhbt.net>

Eric Wong <e@yhbt.net> wrote:
> +	my ($self, $dir) = @_;
> +	my ($fh, $fn) = tempfile('msgmap-XXXXXXXX', EXLOCK => 0, DIR => $dir);
>  	my $tmp;
>  	if ($self->{dbh}->can('sqlite_backup_to_dbh')) {
>  		$tmp = ref($self)->new_file($fn, 2);
> diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
> index 6908bd2e..6b0bdc73 100644
> --- a/lib/PublicInbox/V2Writable.pm
> +++ b/lib/PublicInbox/V2Writable.pm
> @@ -1225,7 +1225,7 @@ sub index_sync {
>  		# only for batch performance.
>  		$self->{mm}->{dbh}->rollback;
>  		$self->{mm}->{dbh}->begin_work;
> -		$sync->{mm_tmp} = $self->{mm}->tmp_clone;
> +		$sync->{mm_tmp} = $self->{mm}->tmp_clone($self->{inboxdir});

That is wrong, and the `undef' didn't get noticed since
tempfile() sees `DIR => undef' and just uses the current
working directory.  Will squash this in:

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 6b0bdc73..e071bc1e 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1225,7 +1225,8 @@ sub index_sync {
 		# only for batch performance.
 		$self->{mm}->{dbh}->rollback;
 		$self->{mm}->{dbh}->begin_work;
-		$sync->{mm_tmp} = $self->{mm}->tmp_clone($self->{inboxdir});
+		$sync->{mm_tmp} =
+			$self->{mm}->tmp_clone($self->{ibx}->{inboxdir});
 	}
 	if ($sync->{index_max_size} = $self->{ibx}->{index_max_size}) {
 		$sync->{index_oid} = \&index_oid;

      reply	other threads:[~2020-07-29 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 23:25 [PATCH] v2writable: use {inboxdir} for msgmap->tmp_clone Eric Wong
2020-07-29 11:32 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729113224.GB7999@dcvr \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).