[RFC] mda: use PublicInbox::Address to extract emails

[RFC] mda: use PublicInbox::Address to extract emails

[Eric Wong]

I'm not sure why this wasn't done in Jun/July 2016 when I was
working on PublicInbox::Address to replace the DoS-vulnerable
Email::Address.

Nowadays, PublicInbox::Address allows using Email::Address::XS
which should be fast and robust.
---
 lib/PublicInbox/MDA.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
index 57b436b9..fa4a2ad8 100644
--- a/lib/PublicInbox/MDA.pm
+++ b/lib/PublicInbox/MDA.pm
@@ -6,6 +6,7 @@ package PublicInbox::MDA;
 use strict;
 use warnings;
 use PublicInbox::MsgTime;
+use PublicInbox::Address;
 use constant MAX_SIZE => 1024 * 500; # same as spamc default, should be tunable
 use constant MAX_MID_SIZE => 244; # max term size - 1 in Xapian
 
@@ -62,7 +63,7 @@ sub alias_specified {
 	} @address;
 
 	foreach my $line ($simple->header('Cc'), $simple->header('To')) {
-		my @addrs = ($line =~ /([^,<\s]+\@[^,>\s]+)/g);
+		my @addrs = PublicInbox::Address::emails($line);
 		foreach my $addr (@addrs) {
 			if ($ok{lc(__drop_plus($addr))}) {
 				return 1;

Re: [RFC] mda: use PublicInbox::Address to extract emails

[Eric Wong]

Eric Wong <e@yhbt.net> wrote:
> I'm not sure why this wasn't done in Jun/July 2016 when I was
> working on PublicInbox::Address to replace the DoS-vulnerable
> Email::Address.

*shrug* probably just a brain fart back in the day.

> Nowadays, PublicInbox::Address allows using Email::Address::XS
> which should be fast and robust.

Been kinda wondering if Perl 5.10 RE grammars can get the job
done w/o involving XS or having DoS vulnerabilities of non-XS
Email::Address...

Anyways, pushed as commit c0f3095c2f0fdf3409a2d7bc629230cd83a06f9f