From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: Re: [PATCH] inboxidle: avoid per-inbox anonymous subs
Date: Thu, 2 Jul 2020 19:50:51 +0000 [thread overview]
Message-ID: <20200702195051.GA71258@dcvr> (raw)
In-Reply-To: <20200702033256.15643-1-e@yhbt.net>
Keeping comments and code synced is hard :x
Will squash before pushing
diff --git a/lib/PublicInbox/DirIdle.pm b/lib/PublicInbox/DirIdle.pm
index 2915fd6e..89cce305 100644
--- a/lib/PublicInbox/DirIdle.pm
+++ b/lib/PublicInbox/DirIdle.pm
@@ -45,7 +45,7 @@ sub event_step {
my ($self) = @_;
my $cb = $self->{cb};
eval {
- my @events = $self->{inot}->read; # Linux::Inotify2::poll
+ my @events = $self->{inot}->read; # Linux::Inotify2->read
$cb->($_) for @events;
};
warn "$self->{inot}->read err: $@\n" if $@;
diff --git a/lib/PublicInbox/KQNotify.pm b/lib/PublicInbox/KQNotify.pm
index 2305daa7..c7740df2 100644
--- a/lib/PublicInbox/KQNotify.pm
+++ b/lib/PublicInbox/KQNotify.pm
@@ -56,7 +56,7 @@ sub on_overflow {}
# noop for Linux::Inotify2 compatibility, we use `0' timeout for ->kevent
sub blocking {}
-# behave like Linux::Inotify2::poll
+# behave like Linux::Inotify2->read
sub read {
my ($self) = @_;
my @kevents = $self->{dskq}->{kq}->kevent(0);
prev parent reply other threads:[~2020-07-02 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 3:32 [PATCH] inboxidle: avoid per-inbox anonymous subs Eric Wong
2020-07-02 19:50 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702195051.GA71258@dcvr \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).