unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 5/5] overidx: document why we don't use SQLite WAL
Date: Wed,  1 Jul 2020 21:06:19 +0000	[thread overview]
Message-ID: <20200701210619.29601-6-e@yhbt.net> (raw)
In-Reply-To: <20200701210619.29601-1-e@yhbt.net>

I was wondering about this myself the other day and had to read
up on it.  So make a note of it for future readers.
---
 lib/PublicInbox/OverIdx.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index c7f45a6c910..008a5d1a936 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -23,6 +23,8 @@ sub dbh_new {
 	my $dbh = $self->SUPER::dbh_new(1);
 
 	# TRUNCATE reduces I/O compared to the default (DELETE)
+	# We do not use WAL since we're optimized for read-only ops,
+	# (and read-only requires SQLite 3.22.0 (2018-01-22)).
 	$dbh->do('PRAGMA journal_mode = TRUNCATE');
 
 	# 80000 pages (80MiB on SQLite <3.12.0, 320MiB on 3.12.0+)

  parent reply	other threads:[~2020-07-01 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 21:06 [PATCH 0/5] some random minor fixes Eric Wong
2020-07-01 21:06 ` [PATCH 1/5] spawn: make @RLIMITS an array Eric Wong
2020-07-01 21:06 ` [PATCH 2/5] spawn: modernize with parent.pm, drop warnings.pm Eric Wong
2020-07-01 21:06 ` [PATCH 3/5] watch: retry signals to kill IDLE and polling processes Eric Wong
2020-07-01 21:06 ` [PATCH 4/5] tests: add use/require statements for TEST_RUN_MODE=0 Eric Wong
2020-07-01 21:06 ` Eric Wong [this message]
2020-07-02 20:12 ` [PATCH 6/5] spawn: drop unused sys/uio.h include Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701210619.29601-6-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).