unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] searchidx: v1: fix retries when Xapian and Msgmap are out-of-sync
@ 2020-06-05  2:01 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-06-05  2:01 UTC (permalink / raw)
  To: meta

We forcibly stop git-log here, so erroring out on git-log close
failures is wrong since it sees SIGPIPE.  Noticed while
reindexing a large v1 inbox for IMAP changes.

Fixes: b32b47fb12a3043d ("index: "git log" failures are fatal")
---
 lib/PublicInbox/SearchIdx.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 5c161b9a..f7462aa7 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -754,10 +754,7 @@ sub _index_sync {
 	my $xdb = $self->begin_txn_lazy;
 	my $mm = _msgmap_init($self);
 	do {
-		if ($xlog) {
-			close($xlog) or die "git log failed: \$?=$?";
-			$xlog = undef;
-		}
+		$xlog = undef; # stop previous git-log via SIGPIPE
 		$last_commit = _last_x_commit($self, $mm);
 		$lx = reindex_from($opts->{reindex}, $last_commit);
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-05  2:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05  2:01 [PATCH] searchidx: v1: fix retries when Xapian and Msgmap are out-of-sync Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).