From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0D9571FA0B for ; Mon, 1 Jun 2020 10:06:58 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 03/13] v2writable: fix non-sensical interpolation in BUG message Date: Mon, 1 Jun 2020 10:06:47 +0000 Message-Id: <20200601100657.14700-4-e@yhbt.net> In-Reply-To: <20200601100657.14700-1-e@yhbt.net> References: <20200601100657.14700-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No point in attempting to print the value of an undefined variable if there's a bug. Fortunately, (AFAIK) we've never hit that bug check :> --- lib/PublicInbox/V2Writable.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index b393b31f0e2..1a824531f3c 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -182,7 +182,7 @@ sub _add { my ($num, $mid0) = v2_num_for($self, $mime); defined $num or return; # duplicate - defined $mid0 or die "BUG: $mid0 undefined\n"; + defined $mid0 or die "BUG: \$mid0 undefined\n"; my $im = $self->importer; my $smsg = bless { mid => $mid0, num => $num }, 'PublicInbox::Smsg'; my $cmt = $im->add($mime, undef, $smsg); # sets $smsg->{ds|ts|blob}