unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: Re: [PATCH] index: add --batch-size=SIZE option
Date: Mon, 18 May 2020 03:04:41 +0000	[thread overview]
Message-ID: <20200518030441.GB32411@dcvr> (raw)
In-Reply-To: <20200517193721.29185-1-e@yhbt.net>

Eric Wong <e@yhbt.net> wrote:
> On powerful systems, having this option is preferable to
> XAPIAN_FLUSH_THRESHOLD due to lock granularity and contention
> with other processes (-learn, -mda, -watch).
> 
> Setting XAPIAN_FLUSH_THRESHOLD can cause -learn, -mda, and
> -watch to get stuck until an epoch is completely processed.

Fwiw, I've debated with myself on-and-off for a number of years
about adding this knob.

I don't like tuning knobs in general because it's more stuff to
document and support, and more stuff for new users to learn.

However, it's tough to tell how much memory a user is willing to
spend or how long they're willing to wait for -mda/-watch
deliveries while --reindex is happening.  So the default is to
remain conservative and lean towards suboptimal throughput
rather than trigger a swap storm or OOM.

      parent reply	other threads:[~2020-05-18  3:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17 19:37 [PATCH] index: add --batch-size=SIZE option Eric Wong
2020-05-17 23:54 ` Kyle Meyer
2020-05-18  2:39   ` Eric Wong
2020-05-18  3:04 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200518030441.GB32411@dcvr \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).