From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 09B661F8C1 for ; Wed, 6 May 2020 00:43:04 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] git: warn on ->cat_async callback errors Date: Wed, 6 May 2020 00:43:03 +0000 Message-Id: <20200506004303.90311-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This will help us track down bugs in our own code when it comes to missing error checking. --- lib/PublicInbox/Git.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 057135ef..8426cc7d 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -147,6 +147,7 @@ sub _cat_async_step ($$) { my ($oid_hex, $type, $size) = ($1, $2, $3 + 0); my $bref = read_cat_in_full($self, $size); eval { $cb->($bref, $oid_hex, $type, $size, $arg) }; + warn "E: $oid_hex $@\n" if $@; } sub cat_async_wait ($) {