unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] git: warn on ->cat_async callback errors
@ 2020-05-06  0:43 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-05-06  0:43 UTC (permalink / raw)
  To: meta

This will help us track down bugs in our own code when
it comes to missing error checking.
---
 lib/PublicInbox/Git.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 057135ef..8426cc7d 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -147,6 +147,7 @@ sub _cat_async_step ($$) {
 	my ($oid_hex, $type, $size) = ($1, $2, $3 + 0);
 	my $bref = read_cat_in_full($self, $size);
 	eval { $cb->($bref, $oid_hex, $type, $size, $arg) };
+	warn "E: $oid_hex $@\n" if $@;
 }
 
 sub cat_async_wait ($) {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-06  0:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  0:43 [PATCH] git: warn on ->cat_async callback errors Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).