From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7422D1F8C3 for ; Fri, 1 May 2020 18:04:45 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] t/convert-compact: avoid warning on `scalar(split(...))' Date: Fri, 1 May 2020 18:04:45 +0000 Message-Id: <20200501180445.16513-3-e@yhbt.net> In-Reply-To: <20200501180445.16513-1-e@yhbt.net> References: <20200501180445.16513-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Perl 5.10.1 would warn about implicit assignment to @_ by split(). So favor the documented method of using `tr' to count lines. Fixes: b5ddcb3352ef31ae ("index: support --compact / -c on command-line") --- t/convert-compact.t | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/convert-compact.t b/t/convert-compact.t index ae299021..1627e019 100644 --- a/t/convert-compact.t +++ b/t/convert-compact.t @@ -124,7 +124,6 @@ $rdr->{2} = \(my $err2 = ''); $cmd = [ qw(-index --reindex -cc), "$tmpdir/v2" ]; ok(run_script($cmd, undef, $rdr), '--reindex -c -c'); like($err2, qr/xapian-compact/, 'xapian-compact ran (-c -c)'); -ok(scalar(split(/\n/, $err2)) > scalar(split(/\n/, $err)), - '-compacted twice'); +ok(($err2 =~ tr/\n/\n/) > ($err =~ tr/\n/\n/), '-compacted twice'); done_testing();