From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] feed: drop needless version check
Date: Thu, 23 Apr 2020 01:54:52 +0000 [thread overview]
Message-ID: <20200423015452.22656-1-e@yhbt.net> (raw)
We don't need to be checking inbox versions in parts of the WWW
code. Checking the presence of $ibx->over is enough, everywhere.
---
lib/PublicInbox/Feed.pm | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 07347c63..4cb295e6 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -84,15 +84,10 @@ sub recent_msgs {
my ($ctx) = @_;
my $ibx = $ctx->{-inbox};
my $max = $ibx->{feedmax};
- my $qp = $ctx->{qp};
- my $v = $ibx->version;
- if ($v > 2) {
- die "BUG: unsupported inbox version: $v\n";
- }
- if ($ibx->over) {
- return PublicInbox::View::paginate_recent($ctx, $max);
- }
+ return PublicInbox::View::paginate_recent($ctx, $max) if $ibx->over;
+ # only for rare v1 inboxes which aren't indexed at all
+ my $qp = $ctx->{qp};
my $hex = '[a-f0-9]';
my $addmsg = qr!^:000000 100644 \S+ (\S+) A\t${hex}{2}/${hex}{38}$!;
my $delmsg = qr!^:100644 000000 (\S+) \S+ D\t(${hex}{2}/${hex}{38})$!;
reply other threads:[~2020-04-23 1:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423015452.22656-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).