From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [squash] wwwaltid: use gzipfilter up front
Date: Tue, 21 Apr 2020 07:22:45 +0000 [thread overview]
Message-ID: <20200421072245.GA29698@dcvr> (raw)
In-Reply-To: <20200421065734.14216-1-e@yhbt.net>
Eric Wong <e@yhbt.net> wrote:
> This allows us to simplify some of our existing code and make
> future changes easier.
Can't go to the golf course, so Perl golf it is!
diff --git a/lib/PublicInbox/WwwAltId.pm b/lib/PublicInbox/WwwAltId.pm
index 630ed686..e5476d1f 100644
--- a/lib/PublicInbox/WwwAltId.pm
+++ b/lib/PublicInbox/WwwAltId.pm
@@ -8,6 +8,7 @@ use PublicInbox::Qspawn;
use PublicInbox::WwwStream qw(html_oneshot);
use PublicInbox::AltId;
use PublicInbox::Spawn qw(which);
+use PublicInbox::GzipFilter;
our $sqlite3 = $ENV{SQLITE3};
sub sqlite3_missing ($) {
@@ -64,13 +65,6 @@ or
EOF
}
- eval { require PublicInbox::GzipFilter } or
- return html_oneshot($ctx, 501, \<<EOF);
-<pre>gzip output not available
-
-The administrator needs to install the Compress::Raw::Zlib Perl module
-to support gzipped sqlite3 dumps.</pre>
-EOF
$sqlite3 //= which('sqlite3');
if (!defined($sqlite3)) {
return html_oneshot($ctx, 501, \<<EOF);
prev parent reply other threads:[~2020-04-21 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 6:57 [PATCH] make zlib-related modules a hard dependency Eric Wong
2020-04-21 7:22 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421072245.GA29698@dcvr \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).