From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4098B1F4A5 for ; Mon, 30 Mar 2020 18:30:10 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] viewvcs: stream_blob_parse_hdr: fix BIN_DETECT retries Date: Mon, 30 Mar 2020 18:30:09 +0000 Message-Id: <20200330183009.25541-3-e@yhbt.net> In-Reply-To: <20200330183009.25541-1-e@yhbt.net> References: <20200330183009.25541-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: git-cat-file(1) may return less than the $BIN_DETECT value for some blobs, so ensure we repopulate the values in $ctx for retries in that case, otherwise we'll lose `$ctx->{-res}' and die when attempting to use `undef' as an array ref. --- lib/PublicInbox/ViewVCS.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 069937c1..9ec04f48 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -58,6 +58,7 @@ sub stream_blob_parse_hdr { # {parse_hdr} for Qspawn warn "premature EOF on $oid $$logref\n"; return html_page($ctx, 500, $logref); } + @$ctx{qw(-res -logref)} = ($res, $logref); undef; # bref keeps growing } }