From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id DC5BF1F463;
	Fri,  3 Jan 2020 01:50:14 +0000 (UTC)
Date: Fri, 3 Jan 2020 01:50:14 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] build: allow "check" to work in non-git subdirs of
 worktrees
Message-ID: <20200103015014.GA29655@dcvr>
References: <20200102232928.17407-1-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200102232928.17407-1-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> --- a/Makefile.PL
> +++ b/Makefile.PL
> @@ -167,13 +167,14 @@ changed = \$(shell git ls-files -m)
>  dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
>  
>  check-manifest :: MANIFEST
> -	if git ls-files >\$?.gen 2>&1; then diff -u \$? \$?.gen; fi
> +	if test -e .git && git ls-files >\$?.gen 2>&1; then \
> +		diff -u \$? \$?.gen; fi

Oops, forgot to escape the trailing slash :x
(I'm probably still traumatized from the solver regexp :x)

diff --git a/Makefile.PL b/Makefile.PL
index c7c661e8..b8c05cf7 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -167,7 +167,7 @@ changed = \$(shell git ls-files -m)
 dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
 
 check-manifest :: MANIFEST
-	if test -e .git && git ls-files >\$?.gen 2>&1; then \
+	if test -e .git && git ls-files >\$?.gen 2>&1; then \\
 		diff -u \$? \$?.gen; fi
 
 # the traditional way running per-*.t processes: