From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] build: allow "check" to work in non-git subdirs of worktrees
Date: Thu, 2 Jan 2020 23:29:28 +0000 [thread overview]
Message-ID: <20200102232928.17407-1-e@80x24.org> (raw)
Some people will place the contents of an unpacked tarball
inside another directory controlled by git (e.g. a ports tree
or even git-versioned home directory). "git ls-files" will
succeed in those cases, so we must check for the existence
of a ".git" dir, instead.
---
Makefile.PL | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index e9e4e2ab..c7c661e8 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -167,13 +167,14 @@ changed = \$(shell git ls-files -m)
dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
check-manifest :: MANIFEST
- if git ls-files >\$?.gen 2>&1; then diff -u \$? \$?.gen; fi
+ if test -e .git && git ls-files >\$?.gen 2>&1; then \
+ diff -u \$? \$?.gen; fi
# the traditional way running per-*.t processes:
check-each :: pure_all check-manifest
\$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N)
-# lightly-tested way to runn tests, relies "--state=save" in check-each
+# lightly-tested way to run tests, relies "--state=save" in check-each
# for best performance
check-run :: pure_all check-manifest
\$(EATMYDATA) \$(PROVE) -bvw t/run.perl :: -j\$(N)
next reply other threads:[~2020-01-02 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 23:29 Eric Wong [this message]
2020-01-03 1:50 ` [PATCH] build: allow "check" to work in non-git subdirs of worktrees Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102232928.17407-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).