Re: [PATCH 2/2] config: support multi-value inbox.*.*url

[Eric Wong <e@80x24.org>]

Eric Wong <e@80x24.org> wrote:
> +++ b/lib/PublicInbox/Hval.pm
> @@ -86,6 +86,13 @@ sub raw {
>  
>  sub prurl {
>  	my ($env, $u) = @_;
> +	if (ref($u) eq 'ARRAY') {
> +		my $h = $env->{HTTP_HOST} // $env->{SERVER_NAME};
> +		if (my @host_match = grep(/\b\Q$h\E\b/, @$u)) {
> +			return prurl($env, $host_match[0]);
> +		}
> +		$u = $u->[0]; # fall through to below:
> +	}
>  	index($u, '//') == 0 ? "$env->{'psgi.url_scheme'}:$u" : $u;
>  }

No need for recursion, actually :x

diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 0a0de834..cd3a4df3 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -88,10 +88,9 @@ sub prurl {
 	my ($env, $u) = @_;
 	if (ref($u) eq 'ARRAY') {
 		my $h = $env->{HTTP_HOST} // $env->{SERVER_NAME};
-		if (my @host_match = grep(/\b\Q$h\E\b/, @$u)) {
-			return prurl($env, $host_match[0]);
-		}
-		$u = $u->[0]; # fall through to below:
+		my @host_match = grep(/\b\Q$h\E\b/, @$u);
+		$u = $host_match[0] // $u->[0];
+		# fall through to below:
 	}
 	index($u, '//') == 0 ? "$env->{'psgi.url_scheme'}:$u" : $u;
 }