From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 133A21F463;
	Wed, 18 Dec 2019 09:05:14 +0000 (UTC)
Date: Wed, 18 Dec 2019 09:05:13 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 3/6] Makefile.PL: sort target and var lists
Message-ID: <20191218090513.GA1806@dcvr>
References: <20191218033645.5037-1-e@80x24.org>
 <20191218033645.5037-4-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191218033645.5037-4-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> Sorting makes it easier to review the generated result.

> --- a/Makefile.PL
> +++ b/Makefile.PL
> @@ -83,13 +83,13 @@ $v->{rsync_xdocs} = [ @{$v->{gz_xdocs}}, @{$v->{xdocs_html}}, @{$v->{xdocs}} ];
>  my $TGTS = join("\n", map {;
>  	my $tgt_prereq = $_;
>  	my $cmds = $t->{$_};
> -	"$tgt_prereq\n".join('', map { "\t$_\n" } @$cmds);
> -} keys %$t);
> +	"$tgt_prereq\n".join('', map { "\t$_\n" } sort(@$cmds));

That sort is very wrong :x                        ^^^^
Will squash this in before merging.

diff --git a/Makefile.PL b/Makefile.PL
index 0f8e1b74..7ea1ee08 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -83,7 +83,7 @@ $v->{rsync_xdocs} = [ @{$v->{gz_xdocs}}, @{$v->{xdocs_html}}, @{$v->{xdocs}} ];
 my $TGTS = join("\n", map {;
 	my $tgt_prereq = $_;
 	my $cmds = $t->{$_};
-	"$tgt_prereq\n".join('', map { "\t$_\n" } sort(@$cmds));
+	"$tgt_prereq\n".join('', map { "\t$_\n" } @$cmds);
 } sort keys %$t);
 
 my $VARS = join("\n", map {;