From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 3/6] Makefile.PL: sort target and var lists
Date: Wed, 18 Dec 2019 09:05:13 +0000 [thread overview]
Message-ID: <20191218090513.GA1806@dcvr> (raw)
In-Reply-To: <20191218033645.5037-4-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> Sorting makes it easier to review the generated result.
> --- a/Makefile.PL
> +++ b/Makefile.PL
> @@ -83,13 +83,13 @@ $v->{rsync_xdocs} = [ @{$v->{gz_xdocs}}, @{$v->{xdocs_html}}, @{$v->{xdocs}} ];
> my $TGTS = join("\n", map {;
> my $tgt_prereq = $_;
> my $cmds = $t->{$_};
> - "$tgt_prereq\n".join('', map { "\t$_\n" } @$cmds);
> -} keys %$t);
> + "$tgt_prereq\n".join('', map { "\t$_\n" } sort(@$cmds));
That sort is very wrong :x ^^^^
Will squash this in before merging.
diff --git a/Makefile.PL b/Makefile.PL
index 0f8e1b74..7ea1ee08 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -83,7 +83,7 @@ $v->{rsync_xdocs} = [ @{$v->{gz_xdocs}}, @{$v->{xdocs_html}}, @{$v->{xdocs}} ];
my $TGTS = join("\n", map {;
my $tgt_prereq = $_;
my $cmds = $t->{$_};
- "$tgt_prereq\n".join('', map { "\t$_\n" } sort(@$cmds));
+ "$tgt_prereq\n".join('', map { "\t$_\n" } @$cmds);
} sort keys %$t);
my $VARS = join("\n", map {;
next prev parent reply other threads:[~2019-12-18 9:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 3:36 [PATCH 0/6] test updates and speedups Eric Wong
2019-12-18 3:36 ` [PATCH 1/6] TODO: add UUCP address item Eric Wong
2019-12-18 3:36 ` [PATCH 2/6] viewvcs: flesh out some functionality and test Eric Wong
2019-12-18 3:36 ` [PATCH 3/6] Makefile.PL: sort target and var lists Eric Wong
2019-12-18 9:05 ` Eric Wong [this message]
2019-12-18 3:36 ` [PATCH 4/6] t/*.t: avoid sharing "my" variables in subs Eric Wong
2019-12-18 3:36 ` [PATCH 5/6] tests: move t/common.perl to PublicInbox::TestCommon Eric Wong
2019-12-19 4:02 ` Eric Wong
2019-12-18 3:36 ` [PATCH 6/6] t/run.perl: to avoid repeated process spawning for *.t Eric Wong
2019-12-19 4:03 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218090513.GA1806@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).