From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6117D1F5A6 for ; Fri, 15 Nov 2019 09:51:01 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 04/29] index: pass global variables into subs Date: Fri, 15 Nov 2019 09:50:35 +0000 Message-Id: <20191115095100.25633-5-e@80x24.org> In-Reply-To: <20191115095100.25633-1-e@80x24.org> References: <20191115095100.25633-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Avoid 'Variable "%s" will not stay shared' warnings when the contents of this script eval'ed into a sub. --- script/public-inbox-index | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/script/public-inbox-index b/script/public-inbox-index index 139b6e56..102381c3 100755 --- a/script/public-inbox-index +++ b/script/public-inbox-index @@ -18,11 +18,10 @@ GetOptions($opt, qw(verbose|v+ reindex jobs|j=i prune indexlevel|L=s)) or die "bad command-line args\n$usage"; die "--jobs must be positive\n" if defined $opt->{jobs} && $opt->{jobs} <= 0; -sub usage { print STDERR "Usage: $usage\n"; exit 1 } my @ibxs = PublicInbox::Admin::resolve_inboxes(\@ARGV); PublicInbox::Admin::require_or_die('-index'); -usage() unless @ibxs; +unless (@ibxs) { print STDERR "Usage: $usage\n"; exit 1 } my $mods = {}; foreach my $ibx (@ibxs) { # XXX: users can shoot themselves in the foot, with opt->{indexlevel}