From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/3] v2writable: move git->cleanup to the correct place
Date: Tue, 22 Oct 2019 01:28:41 +0000 [thread overview]
Message-ID: <20191022012841.GA7175@dcvr> (raw)
In-Reply-To: <20191021110221.23753-4-e@80x24.org>
We need to stop the git process to avoid leaking FDs
to Xapian if we recurse ->index_sync on reindex.
---
lib/PublicInbox/V2Writable.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 7ece6b01..33c0038d 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1280,8 +1280,8 @@ sub index_sync {
$self->{current_info} = "multi_mid $oid";
reindex_oid_m($self, $sync, $git, $oid);
}
- $git->cleanup if $git;
}
+ $git->cleanup if $git;
$self->done;
if (my $nr = $sync->{nr}) {
next prev parent reply other threads:[~2019-10-22 1:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 21:14 BUG: --reindex broken on multiple Message-IDs reuse Eric Wong
2019-10-17 11:22 ` [RFC] v2writable: reindex handles 3-headed monsters [was: BUG: --reindex broken on multiple Message-IDs reuse] Eric Wong
2019-10-22 8:09 ` [RFC/HELP] search: multiple From/To/Cc/Subject (what about Date?) Eric Wong
2019-10-21 11:02 ` [PATCH 0/3] fix reindex on multiple + overlapping Message-IDs Eric Wong
2019-10-21 11:02 ` [PATCH 1/3] v2writable: set unindexed article number Eric Wong
2019-10-21 11:02 ` [PATCH 2/3] v2writable: improve "num_for" API and disambiguate Eric Wong
2019-10-21 11:02 ` [PATCH 3/3] v2writable: reindex handles 3-headered monsters Eric Wong
2019-10-21 11:34 ` Eric Wong
2019-10-22 1:28 ` Eric Wong [this message]
2019-10-22 1:29 ` [PATCH 5/3] v2writable: use msgmap as multi_mid queue Eric Wong
2019-10-23 18:19 ` [PUSHED] fix reindex on multiple + overlapping Message-IDs Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022012841.GA7175@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).