From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: Git-only operation mode
Date: Thu, 26 Sep 2019 17:44:17 -0400 [thread overview]
Message-ID: <20190926214417.GE10467@chatter.i7.local> (raw)
In-Reply-To: <20190926211025.GA11146@dcvr>
On Thu, Sep 26, 2019 at 09:10:25PM +0000, Eric Wong wrote:
>If grok-pull is using multiple threads, there can be a race
>there because parallel runs of public-inbox-init can clobber
>each other (which needs to be fixed :x)
Yes, this is true -- there should be a lockfile in the hook to avoid
multiple post-update-hook's from operating on the same pidir.
>> # Need logic here for adding to the config file
>
>Yeah, I've been meaning to add something like "$INBOX_URL/_/text/config"
>so some of the config keys can be easily cloned, too.
>
>Not sure if it's something that can be stuffed in manifest.js.gz
>or better as a separate file... Probably separate file?
Right -- the manifest only deals with very basic repository details, so
it's easier to pass this info in some other way. Either via a remote
URL, or perhaps via a file in a special ref in the repo itself
(refs/meta/config?). We use this trick on git.kernel.org to let people
tweak cgit parameters for their repos, see
https://korg.wiki.kernel.org/userdoc/cgit-meta-data.
-K
next prev parent reply other threads:[~2019-09-26 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 18:24 Git-only operation mode Konstantin Ryabitsev
2019-09-25 19:45 ` Eric Wong
2019-09-25 19:58 ` Konstantin Ryabitsev
2019-09-25 22:45 ` Eric Wong
2019-09-26 0:23 ` Eric W. Biederman
2019-09-26 20:52 ` Konstantin Ryabitsev
2019-09-26 21:10 ` Eric Wong
2019-09-26 21:44 ` Konstantin Ryabitsev [this message]
2019-10-07 0:07 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926214417.GE10467@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).