From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8A2021F463 for ; Thu, 26 Sep 2019 12:36:10 +0000 (UTC) Received: by mail-qk1-x743.google.com with SMTP id x134so1615216qkb.0 for ; Thu, 26 Sep 2019 05:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PHaAzQZMOnMcdHKMXOLc4OzAegOoDggU3THBqSAtuYw=; b=PvI3qvcbER+jePToChwl6WzxS+aHTxuO0BASj0DBa4NxODj4Ewl5YY6Txn90EC3R0T szGG4X9Cvr3Yy3Uz1e3xBgL31LXKD0vWupeaaN4usszwtyjF+8BrT8dtNjBngR99Vu08 anWuQmMcZuA+QSvJt+J2GxERXhpR4WUOalX0k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PHaAzQZMOnMcdHKMXOLc4OzAegOoDggU3THBqSAtuYw=; b=Xi0NcoC9f5YUhy1udfynFI+3dLSSw66Py9usirHyDYwiuw8ao7c+hOGg1gl+bFMoLG sk7HocHz5Jn5oXh/Jlsnr6UFBopI3sYHlJlvbTo/BC1cIKxN0wCFopsrcB41nxcZn96o j8OS8uNaKIDQm9soNZs+xeyRp7pMI3KqOUBQMgswKqSgrLAlQeeFII0KeT61TR6OJJSd InhrJC8vRogk9LrIQivXcORS9SymvNgEue2UNAi7/yGltcYWA2W9DgkzITYrFRJQSLB4 OiVJbqEHBWZp2y+NBubnl32z+eQ5MbQJg5L1gPyNLDmG9xEy8iqua788v80LDR7/LKjT bY+g== X-Gm-Message-State: APjAAAUxoxZZRn+RzD8jHZoppnqsoVvUyMlrrQ1Od/RSSgcjjS/YxbeK IEZP3zvxnE3WTdCE6Ikbhr0eDw== X-Google-Smtp-Source: APXvYqw3k9qjt0ik0GNENX09HJ48kbvhv5d3MfbS7oDzut1j9IONpvtkla0XvqK33fSfFgOP5fdSvA== X-Received: by 2002:a37:9944:: with SMTP id b65mr2890643qke.175.1569501369265; Thu, 26 Sep 2019 05:36:09 -0700 (PDT) Received: from chatter.i7.local (192-0-228-88.cpe.teksavvy.com. [192.0.228.88]) by smtp.gmail.com with ESMTPSA id e11sm843502qkg.134.2019.09.26.05.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 05:36:08 -0700 (PDT) Date: Thu, 26 Sep 2019 08:36:06 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH 0/2] leak workarounds for Perl 5.16 on CentOS/RHEL 7 Message-ID: <20190926123606.GA10467@chatter.i7.local> References: <20190926015038.29770-1-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20190926015038.29770-1-e@80x24.org> User-Agent: Mutt/1.12.1 (2019-06-15) List-Id: On Thu, Sep 26, 2019 at 01:50:36AM +0000, Eric Wong wrote: >After many hours of reviewing our code in PublicInbox::Qspawn, >PublicInbox::GitHTTPBackend, and PublicInbox::HTTP and finding >nothing but cleanups and documentation improvements; it seems >the leaks affecting lore is down to bugs in Perl 5.16.3. > >After removing the warning for Deflater being missing in >d883d4a93b23be134038e28f421eafca70c3d838 >("httpd: get rid of Deflater warning"), I missed that my >own CentOS 7 VM was missing that module so was unable to >reproduce the FD leaks :x > >The first patch is a straightforward workaround that I was >able to test without Plack::Middleware::Deflater being installed. > >The second patch stops loading Deflater in httpd on Perls >earlier than 5.18. (But I haven't built or tested 5.18 myself). >Enabling gzip in varnish will be needed for 5.16 users. Yay, I can confirm that the latest master fixes all the FD leaks that have been plaguing lore.kernel.org for the past few weeks. The number of pipes is stable and there are no (deleted) tempfiles showing up. Thanks so much for this! Can you elaborate on gzip+varnish changes? I'm assuming it's something as simple as: @@ -63,6 +63,10 @@ } else { /* short TTL for up-to-dateness, our PSGI is not that slow */ set beresp.ttl = 10s; + /* Compress text responses on CentOS7 */ + if (beresp.http.content-type ~ "text") { + set beresp.do_gzip = true; + } } return (deliver); } -K