unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Alyssa Ross <hi@alyssa.is>
Cc: meta@public-inbox.org, Amitai Schleier <schmonz-web-ikiwiki@schmonz.com>
Subject: Re: [PATCH] hlmod: update for highlight 3.51 API change
Date: Thu, 26 Sep 2019 01:59:53 +0000	[thread overview]
Message-ID: <20190926015953.GA4445@dcvr> (raw)
In-Reply-To: <20190924200551.31014-1-hi@alyssa.is>

Alyssa Ross <hi@alyssa.is> wrote:
> Quoting Amitai Schleier, who made this same change in ikiwiki[1],
> where lots of the public-inbox highlight code comes from:
> 
> > As of 3.51, searchFile() is no longer provided in highlight's Perl
> > bindings (at least on NetBSD and OS X, as built from pkgsrc). This
> > leaves us falling through to getConfDir(), which has been gone
> > rather longer.
> >
> > From highlight git, it appears searchFile() and getFiletypesConfPath()
> > both originated in the 3.14 release. The latter is still available in
> > 3.51, and returns the same result searchFile() used to. Switch to it.
> 
> So, this should still be compatible with the version of highlight.pm in
> Debian, but add support for newer versions as well.
> 
> [1]: commit 4d06df9583e6c4145f8c6fc2fd51d7894c0b85ce

Thanks both, pushed as dadaf7fd96301f1737b2eca2171a742daef8befd

I had my reservations about relying on highlight.pm; and this
confirms them, unfortunately :<  Oh well...

I wonder if pygments or any other code highlighting packages are
more stable.  We'd need to use a pipe or socket to interact with
pygments or anything w/o Perl bindings.

  reply	other threads:[~2019-09-26  1:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 20:05 [PATCH] hlmod: update for highlight 3.51 API change Alyssa Ross
2019-09-26  1:59 ` Eric Wong [this message]
2019-09-26 13:18   ` Konstantin Ryabitsev
2019-09-26 15:07     ` Alyssa Ross
2019-10-08 21:53     ` [PATCH] TODO: add an item for Python pygments Eric Wong
2019-10-08 22:00       ` Konstantin Ryabitsev
2019-09-26 15:08   ` [PATCH] hlmod: update for highlight 3.51 API change Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926015953.GA4445@dcvr \
    --to=e@80x24.org \
    --cc=hi@alyssa.is \
    --cc=meta@public-inbox.org \
    --cc=schmonz-web-ikiwiki@schmonz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).