From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 757E71F463 for ; Thu, 12 Sep 2019 23:16:52 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] githttpbackend: use REMOTE_ADDR for deleted identifier Date: Thu, 12 Sep 2019 23:16:52 +0000 Message-Id: <20190912231652.14816-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: REMOTE_HOST is not set by us (it is the reverse DNS name) of REMOTE_ADDR, and there's few better ways to kill HTTP server performance than to use standard name resolution APIs like getnameinfo(3). --- lib/PublicInbox/GitHTTPBackend.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm index a8337035..c9a7cff8 100644 --- a/lib/PublicInbox/GitHTTPBackend.pm +++ b/lib/PublicInbox/GitHTTPBackend.pm @@ -219,7 +219,7 @@ sub input_prepare { if (defined $fd && $fd >= 0) { return { 0 => $fd }; } - my $id = "git-http.input.$env->{REMOTE_HOST}:$env->{REMOTE_PORT}"; + my $id = "git-http.input.$env->{REMOTE_ADDR}:$env->{REMOTE_PORT}"; my $in = tmpfile($id); unless (defined $in) { err($env, "could not open temporary file: $!");