unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] githttpbackend: use REMOTE_ADDR for deleted identifier
@ 2019-09-12 23:16 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-09-12 23:16 UTC (permalink / raw)
  To: meta

REMOTE_HOST is not set by us (it is the reverse DNS name) of
REMOTE_ADDR, and there's few better ways to kill HTTP server
performance than to use standard name resolution APIs like
getnameinfo(3).
---
 lib/PublicInbox/GitHTTPBackend.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index a8337035..c9a7cff8 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -219,7 +219,7 @@ sub input_prepare {
 	if (defined $fd && $fd >= 0) {
 		return { 0 => $fd };
 	}
-	my $id = "git-http.input.$env->{REMOTE_HOST}:$env->{REMOTE_PORT}";
+	my $id = "git-http.input.$env->{REMOTE_ADDR}:$env->{REMOTE_PORT}";
 	my $in = tmpfile($id);
 	unless (defined $in) {
 		err($env, "could not open temporary file: $!");

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-12 23:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-12 23:16 [PATCH] githttpbackend: use REMOTE_ADDR for deleted identifier Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).