From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] githttpbackend: use REMOTE_ADDR for deleted identifier
Date: Thu, 12 Sep 2019 23:16:52 +0000 [thread overview]
Message-ID: <20190912231652.14816-1-e@80x24.org> (raw)
REMOTE_HOST is not set by us (it is the reverse DNS name) of
REMOTE_ADDR, and there's few better ways to kill HTTP server
performance than to use standard name resolution APIs like
getnameinfo(3).
---
lib/PublicInbox/GitHTTPBackend.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index a8337035..c9a7cff8 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -219,7 +219,7 @@ sub input_prepare {
if (defined $fd && $fd >= 0) {
return { 0 => $fd };
}
- my $id = "git-http.input.$env->{REMOTE_HOST}:$env->{REMOTE_PORT}";
+ my $id = "git-http.input.$env->{REMOTE_ADDR}:$env->{REMOTE_PORT}";
my $in = tmpfile($id);
unless (defined $in) {
err($env, "could not open temporary file: $!");
reply other threads:[~2019-09-12 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912231652.14816-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).