From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] viewdiff: do not anchor using diffstat comments
Date: Fri, 5 Jul 2019 10:55:59 +0200 [thread overview]
Message-ID: <20190705085559.GG20404@szeder.dev> (raw)
In-Reply-To: <20190705040618.gnbg6jvzqqcn3i5e@dcvr>
On Fri, Jul 05, 2019 at 04:06:18AM +0000, Eric Wong wrote:
> Eric Wong <e@80x24.org> wrote:
> > SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > > https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/
>
> Btw, I'm not sure if the "(new +x)" and all the surrounding
> spaces should be clickable. I have poor coordination, so when I
> (rarely) use a mouse I prefer bigger targets to click; but maybe
> it can get confusing...
FWIW, I didn't find it odd or surprising that the "(new +x)" is part
of the link, and its color clearly indicates that it is part of the
link.
I haven't yet noticed that all the spaces following the filename are
clickable as well, because they don't look like part of the link
(well, being spaces, they don't have any color...), and haven't
noticed the cursor changing shape when hovering over them.
I'm not so sure about this, and think that it can be
confusing/undesired in some circumstances. A user can click on any
"inactive" part of the browser window (i.e. what isn't a link, a
button, or any active GUI widget) to focus and raise the window
without any other effects, so they might just happen to click on
those unsuspicious spaces because they don't look like a link, and
then be surprised when the page jumps to corresponding diff.
next prev parent reply other threads:[~2019-07-05 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 23:11 broken link in diffstat for new files SZEDER Gábor
2019-07-05 4:03 ` [PATCH] viewdiff: do not anchor using diffstat comments Eric Wong
2019-07-05 4:06 ` Eric Wong
2019-07-05 8:55 ` SZEDER Gábor [this message]
2020-01-04 9:16 ` [PATCH] viewdiff: do not anchor spaces after filenames in diffstat Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705085559.GG20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).