From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, FROM_EXCESS_BASE64,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_PDS_NO_HELO_DNS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BFFCE1F461 for ; Thu, 4 Jul 2019 23:11:29 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id v14so8025301wrr.4 for ; Thu, 04 Jul 2019 16:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=uFHqrXCooEjLvNj4VR/is/i+aRQ090Lt//r/+t7mSr4=; b=CzNwp7hfSJSjm2cRaMIrtuzMW+3K+IcoR1CDcA1G8XE66nNcZ2Ssa9PjZGIQgsprut DVosM6VKrsDOvpyAPlPNX5dWKnyLLbK1dSyZyBOenmD//xNcT512jTubCF9+yoiG4UxS BoX2fvF6L6Ln/Vpt0vzx+PyTvfPwF5I12xP6FnMVZqByH9wgmENuwxY78uLsLsF4F8Lz 0wiDc5W2Pz6j4UV66kyq8yaSJ6aBVaxgBzVQzFGsuwvBZjM73r2DI6OKcI1nhd/pvCEP tvemou/P51J3TGlojuZKAobq8PnJ9gEHuvpOTUOmhlwyOhtQSgU2iMJfQAZSjRunx1y/ WuRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=uFHqrXCooEjLvNj4VR/is/i+aRQ090Lt//r/+t7mSr4=; b=hxfF6cIct88lHZVxzSAmUn2ULEpuRRu0y/E5DuUCrIixjsRIaB3+jgY7wZxTf5oeTC crAmSW24SDLYLPtJrkS/5WBj6qwaUIhS+Qu/FGmmu3uA6/ie89xFFFuyNHwpEpcFGL2l eA8zgl0F3pOwR3N5c4p8C4nrKHQ/f+O3wCXrrRBl7/nYjfegYfwuN3LIZliGTlbMtXXB GkMWf1CqD0c+YEYXQ/sRZyv9mZso+lkpG1Wf2yYuycgQMVHQnxCjht1zSuDUj0lT610y 2Uve764nPoJXK93QrXO748xzTMljNRIwTwYIQ1cgQCxWhvrCNh5cPfEx1YdIl16j9jbV NmSQ== X-Gm-Message-State: APjAAAX0U6W0B4/dJ/ADmza5QmqwyRHkRsKxHP7dBc7EN+NbsBUVCSES TPx2+DC+Cw1aEWvTr9tOub7FmIaw X-Google-Smtp-Source: APXvYqwApgMNoy5VhG20H7XVm76sVuhBZaBndg4yavvHpR8zbKTklM3cJAoTeP2SnX5pxYqxw/ZE5w== X-Received: by 2002:a5d:4a46:: with SMTP id v6mr525520wrs.105.1562281886217; Thu, 04 Jul 2019 16:11:26 -0700 (PDT) Received: from szeder.dev (x4db60912.dyn.telefonica.de. [77.182.9.18]) by smtp.gmail.com with ESMTPSA id y3sm6460466wrq.30.2019.07.04.16.11.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 16:11:25 -0700 (PDT) Date: Fri, 5 Jul 2019 01:11:23 +0200 From: SZEDER =?utf-8?B?R8OhYm9y?= To: meta@public-inbox.org Subject: broken link in diffstat for new files Message-ID: <20190704231123.GF20404@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: Hi, being able to jump around from diffstat to the diff of a particular file and back by simply clicking on links is great, but it doesn't seem to work with newly added files. Consider this message: https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/ Clicking on the link that is the name of the doc source file or any of the C source of header files in the diffstat jumps to the diff of the particular file, but clicking on the link of any of the two new test files doesn't go anywhere. Conversely, in the "diff --git a/... b/..." lines of the doc and source files the word "diff" is a link pointing back to the diffstat, but in the diff lines of those two new test files there is no link. Several other patches in that patch series add new test files, and all are affected by this issue. Best, Gábor