From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A8EF61F461 for ; Thu, 27 Jun 2019 18:57:26 +0000 (UTC) Received: by mail-qt1-x835.google.com with SMTP id h24so626977qto.0 for ; Thu, 27 Jun 2019 11:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Rrw//J48imtMY0SSrwKR4wmQoaUaUxKsqJ86nNNL6EU=; b=I6FT8kYLBEjYuUfjO09FG4MFwNwiG2JNqMGdVs3EDB6An7s3JjgV/UacqT/3+4dxhv Uj7hJAdfgtY6tjffHslfSTQTF1xZHq0j1Xu1loyagknT5XbjRpCYmS0ib0uKI+W0TlCi N9eRUhbQ4Eom3ZsdqIqy/aNHeMgVXvyws0WdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Rrw//J48imtMY0SSrwKR4wmQoaUaUxKsqJ86nNNL6EU=; b=YJkYUy5jVu369xh8Z4VN2aLLUwBt35P0FDz6/ri8eqsZNVXWDYI9TdbWPLviyGrRW5 wWn/NzzgXsxY32nbxXvWrixuyNkxuRnRAn93GXS7jRjWC0LeZhlstGJZkaCyKzV8KaUX InVRbrEcr3exMvz661XJDpXZ7cfe706eC7PdWoxb5NDqyYTnT9vNqqZxNMGWdsWuMWxL kTl8mPGujDB9md+5CgOq3GDPFg5yx1oOU26+0HoVL9mIuT7ZCcbbAtWMeVTzqqnGCJT3 fipofWpy5ALo7nhM2qi6WGMy3XLvv00iEkiii6iVbODDFjVnTWiiMCAONJ/RNQeVkfj6 WqHQ== X-Gm-Message-State: APjAAAXYpg/f7F4/Rd/g+3iqZn+hOn2TnFxFEFJ5wINUGdCXTQQlvvJw eLi7Wrk+gDFkceL+A4Fm1Te6lg== X-Google-Smtp-Source: APXvYqzv939bAjejD9AjQJCONpSF9tVslClv0GsvT4cU2TH4dYTSLWlTAAXFZWf0ZEenXzULVmLDUA== X-Received: by 2002:ac8:2b49:: with SMTP id 9mr4761626qtv.343.1561661845407; Thu, 27 Jun 2019 11:57:25 -0700 (PDT) Received: from chatter.i7.local (192-0-228-88.cpe.teksavvy.com. [192.0.228.88]) by smtp.gmail.com with ESMTPSA id v4sm1148409qtq.15.2019.06.27.11.57.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 11:57:24 -0700 (PDT) Date: Thu, 27 Jun 2019 14:57:23 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: RFC: marking spam via refs/notes/spam to hide it Message-ID: <20190627185723.GE14570@chatter.i7.local> References: <20190627184251.GC14570@chatter.i7.local> <20190627185236.2mwuoygclytf5m7x@whir> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20190627185236.2mwuoygclytf5m7x@whir> User-Agent: Mutt/1.12.0 (2019-05-25) List-Id: On Thu, Jun 27, 2019 at 06:52:36PM +0000, Eric Wong wrote: >> I'm reluctant to delete spam because it rebases the repository -- for >> large >> ones this can cause excessive downloads to mirrors. A thought occurred to me >> -- would it make sense to just hide spam from the frontend? E.g.: >> >> public-inbox-hide linux-kernel message@id >> >> This would do the following: >> >> - remove that message from search databases >> - attach a refs/notes/spam git-note to that commit >> - tell public-inbox-init/reindex to ignore this commit in the future > >Aside from the git note, public-inbox-learn already does that: > > public-inbox-learn spam > (scans everything in ~/.public-inbox/config since spam is > frequently cross-posted) Ah, that shows how carefully I read docs, I guess. :) Is it possible to just specify a message-id, so that there's no extra step to dump the spam message into a file? >> Seems like it would be easy to do and would give a way to remove spam >> without needing to edit git history. > >It appends to git history, v2 changes the 'm' file to a 'd' >file with the corresponding blob; v1 removes the file from the >tree. It doesn't add blobs to git history, but there'll be >new tree and commit objects. There's no rebasing at all. > >public-inbox-index has always handled unindexing it in mirrors, >too. Right on, thanks! This is certainly along the same lines that I was thinking. -K