From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: RFC: marking spam via refs/notes/spam to hide it
Date: Thu, 27 Jun 2019 14:57:23 -0400 [thread overview]
Message-ID: <20190627185723.GE14570@chatter.i7.local> (raw)
In-Reply-To: <20190627185236.2mwuoygclytf5m7x@whir>
On Thu, Jun 27, 2019 at 06:52:36PM +0000, Eric Wong wrote:
>> I'm reluctant to delete spam because it rebases the repository -- for
>> large
>> ones this can cause excessive downloads to mirrors. A thought occurred to me
>> -- would it make sense to just hide spam from the frontend? E.g.:
>>
>> public-inbox-hide linux-kernel message@id
>>
>> This would do the following:
>>
>> - remove that message from search databases
>> - attach a refs/notes/spam git-note to that commit
>> - tell public-inbox-init/reindex to ignore this commit in the future
>
>Aside from the git note, public-inbox-learn already does that:
>
> public-inbox-learn spam </path/to/message
>
> (scans everything in ~/.public-inbox/config since spam is
> frequently cross-posted)
Ah, that shows how carefully I read docs, I guess. :) Is it possible to
just specify a message-id, so that there's no extra step to dump the
spam message into a file?
>> Seems like it would be easy to do and would give a way to remove spam
>> without needing to edit git history.
>
>It appends to git history, v2 changes the 'm' file to a 'd'
>file with the corresponding blob; v1 removes the file from the
>tree. It doesn't add blobs to git history, but there'll be
>new tree and commit objects. There's no rebasing at all.
>
>public-inbox-index has always handled unindexing it in mirrors,
>too.
Right on, thanks! This is certainly along the same lines that I was
thinking.
-K
next prev parent reply other threads:[~2019-06-27 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 18:42 RFC: marking spam via refs/notes/spam to hide it Konstantin Ryabitsev
2019-06-27 18:52 ` Eric Wong
2019-06-27 18:57 ` Konstantin Ryabitsev [this message]
2019-06-27 19:33 ` Eric Wong
2019-06-27 19:45 ` Konstantin Ryabitsev
2019-06-27 19:50 ` Eric Wong
2019-06-27 20:18 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627185723.GE14570@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).