From: Eric Wong <e@80x24.org>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] searchview: avoid displaying full paths on errors
Date: Wed, 26 Jun 2019 06:35:04 +0000 [thread overview]
Message-ID: <20190626063504.opzyiqyuhtgcfuwo@dcvr> (raw)
In-Reply-To: <DB6PR0501MB2167E55E268AA2BCA3D7EA2DD7E30@DB6PR0501MB2167.eurprd05.prod.outlook.com>
Ali Alnubani <alialnu@mellanox.com> wrote:
> Thanks for the patch Eric.
> I apologize for taking so long to update mine.
No worries. Pushed as c19a4e88f49ba3496751c4b87ebcfa0f6b47f0ce
> > sub err_txt {
> > my ($ctx, $err) = @_;
> > my $u = $ctx->{-inbox}->base_url($ctx->{env}) . '_/text/help/';
> > $err =~ s/^\s*Exception:\s*//; # bad word to show users :P
> > + $err =~ s!(\S+)!path2inc($1)!sge;
One potential issue is this won't match paths if somebody has
spaces in their installation paths. But I suppose few
distros or users building their own Perl are that strange...
prev parent reply other threads:[~2019-06-26 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 19:38 [RFC] searchview: don't be too verbose about bad queries Eric Wong
2019-06-12 8:36 ` Ali Alnubani
2019-06-12 17:18 ` Eric Wong
2019-06-25 6:37 ` [PATCH] searchview: avoid displaying full paths on errors Eric Wong
2019-06-25 7:33 ` Ali Alnubani
2019-06-26 6:35 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626063504.opzyiqyuhtgcfuwo@dcvr \
--to=e@80x24.org \
--cc=alialnu@mellanox.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).