From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 39E961F461; Mon, 24 Jun 2019 23:42:12 +0000 (UTC) Date: Mon, 24 Jun 2019 23:42:12 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: Re: Q: Did you do something to message number recently? Message-ID: <20190624234212.j7ghrejyv7ts7y2u@dcvr> References: <878strvusz.fsf@xmission.com> <20190624163442.xhk6drl7ptnq7i5o@dcvr> <20190624173319.3bb4t3zrieb4k5w2@dcvr> <877e9avbh2.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877e9avbh2.fsf@xmission.com> List-Id: "Eric W. Biederman" wrote: > The add method computes the number using num_for, which uses > Msgmpa::mid_insert. > > Short of the sequence number for msgmap getting scrambled I don't > see how that can go wrong. Sigh. That seems to be what went wrong with "INSERT OR IGNORE" cf. https://public-inbox.org/meta/20190624233809.1721-1-e@80x24.org/ > I will have to instrument my client, and see if that will give > me a clue what is going on. I guess your client ends up seeing the same message over-and-over again like -watch does? > I think most of my previous work was all in the index rebuild path. > Which may be why we don't have a regression test catching this. Yeah, this isn't a new bug at all. I didn't notice since I mainly use w3m or (neo)mutt for NNTP and didn't look too closely at NNTP article numbers. lynx makes it apparent messages are missing: lynx news.public-inbox.org/inbox.comp.lib.glibc.alpha