From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C3FCD1F4BB for ; Mon, 24 Jun 2019 02:52:59 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 05/57] ds: get rid of on_incomplete_write wrapper Date: Mon, 24 Jun 2019 02:52:06 +0000 Message-Id: <20190624025258.25592-6-e@80x24.org> In-Reply-To: <20190624025258.25592-1-e@80x24.org> References: <20190624025258.25592-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Wrong place to be wrapping this method. --- lib/PublicInbox/DS.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index ed04feb5..26c5251b 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -571,7 +571,7 @@ sub write { # since connection has stuff to write, it should now be # interested in pending writes: $self->{wbuf_off} += $written; - $self->on_incomplete_write; + $self->watch_write(1); return 0; } elsif ($written == $to_write) { $self->{wbuf_off} = 0; @@ -590,11 +590,6 @@ sub write { } } -sub on_incomplete_write { - my PublicInbox::DS $self = shift; - $self->watch_write(1); -} - =head2 C<< $obj->watch_read( $boolean ) >> Turn 'readable' event notification on or off. -- EW